Red sky at night, Angel Delight.
Monday, 30 May 2011
The wood pile that used to be trees in my garden.
Fallen off the wagon a little of late with one thing or another. Will be back up to speed shortly.
Tuesday, 24 May 2011
Part of the minidiggers set.
Sunday, 22 May 2011
A daisy beats the odds and grows in the middle of a roundabout
Saturday, 21 May 2011
I've lived in this city all my life, and I've never once noticed this old fashioned red postbox by the cathedral.
Thursday, 19 May 2011
I also took this picture of the outside lip of the cupola. I couldn't decide which to use, but I figured the plant one was unlike anything else I've taken. Here is the other contender.
A view up the Don from Kelham Island. The remains of industry are clearly visible as derelict factories line the river.
An unconventional view of Sheffield Cathedral. The crouching man and wonky bollard break up the straight lines and add a point of interest.
A mish-mash of old, new and middle-aged buildings that I see on my way in to work.
There seems to be an influx of mini-diggers around Sheffield at the moment. This one was heading from West Bar down the pavement towards town.
Monday, 16 May 2011
Saturday, 14 May 2011
I also shot this lovely black and white pic. The B&W, combined with the swirly bokeh of my 28mm Makinon lens, make it appear almost anachronistic.
Thursday, 12 May 2011
Some tiny pink flowers in a vase. And by "in" I actually mean "inside" and not just perched on the top.
Tuesday, 10 May 2011
A rather damp, surprisingly empty Meadowhall carpark turned a little reflective after the downpour.
The second post set in a car park in 3 days. Can you tell what I've been doing a lot of lately? Yep. Shopping in the rain.
Sunday, 8 May 2011
Hero: 108 Kingdom Krashers. A rather silly game involving cannon balls and armoured turtles. £4 from Home Bargains!
A car park through the rain. Lovely effect from the water on glass.
Looking toward Glossop over Hurst Reservoir from the Snake.
Saturday, 7 May 2011
Coding style guidelines are not coding standards. Coding standards are rules on how to construct software. Rules that have practical and defined benefits. Rules than can be proven to assist in the structured and correct building of code. For example:
- Do not perform database access in the constructor.
- All database access should use the framework's DAL.
- Do not rely on complex instantiation instructions; provide a factory method.
- Do not inherit from a class in a different module or library; only encapsulate.
- Avoid singletons.
- Don't maintain state in utility classes.
Another assertion is that automated coding style checking is a static analysis method. Incorrect. It is a way to count whitespace and make sure your curly braces are not out of place. It doesn't check types for logical consistency. It doesn't check variable access for potential casting exceptions. It doesn't ensure that all types are locatable by the class loader. Static analysis tools and lint checkers check far more important things than parenthesis placement.
Ironically, many of the languages where over-zealous application of coding style guidelines is rife are in the dynamic language communities. PHP, Ruby, etc. I say ironically, because they're dynamic languages and cannot, by definition, have static analysis performed on them. That's why they rely so heavily on unit tests.
In these communities, it seems that a meme has taken hold without true understanding. "We need consistency and automation!" they cry, and so they try it. But they put it in all the wrong places. Your code should stand or fall on whether it is logical, correct and understandable. How you choose to indent is your own business.
Coding style guidelines are the lowest form of code analysis. Code reviews in disfunctional teams often degrade to picking spots about coding style.
- Put curly brackets on a new line.
- Put curly brackets on the same line.
- Indent multi-line statements to the first parenthesis.
- Indent multi-line statements one tab stop.
- Put a space between if and (
- Do not put a space between if and (
"If we're spending all our review time picking little, insignificant faults in each other's code rather than checking that it's actually any good, then maybe we should change things?"There were a few possibilities, but the solution they chose was "automate the nit-picking of insignificant whitespace differences." This was the wrong solution. The correct solution would have been
"Why are we nit-picking about whitespace anyway? Are we really that petty? Let's start reviewing based on actual coding standards and unit test results."Failing code for not meeting coding style guidelines precisely is a waste of time. It's arbitrary. It's subjective. There is absolutely no evidence that enforcing coding style in this way has any positive effect on code quality, readability or coherence. However, failing a code review for petty reasons does have negative knock-on effects.
The compiler doesn't care. The user doesn't care. In all practical ways, the coding style guidelines should remain just that; guidelines. The most egregious flaunting of the rules should be flagged in code review. If somebody completely fails to maintain sane indentation, or writes tightly packed code that's hard to decipher, then by all means throw it back. But if the only problem is that somebody's editor indents the last line of a multi-line array in a slightly different way than your standards dictate, lighten up and realise that it doesn't matter at all.
Can anyone out there, in all honestly, compare this:
doSomething( someValue, someOtherValue );and categorically state that one is harder to read than the other? No, because it's subjective. It's all subjective, and it's all arbitrary. Making code functionally and logically correct are objective standards and are provable. Making code readable is entirely subjective and cannot be dictated by failing reviews over hard and fast rules about indenting.
If anyone out there can explain why coding style guidelines have been elevated to this pinnacle, this pedestal, this lofty height to which we mere mortals can only dream to reach, then please enlighten me. As far as I can tell, there is no reason at all beyond cargo cult programming, rhetoric and misunderstanding.
End of rant. Just needed to get that off my chest.
Tuesday, 3 May 2011
A pigeon sits on a telegraph pole while the sun slowly sinks beneath the horizon, illuminating the clouds with sepia.
Sunday, 1 May 2011
This is, of course, why there are a few grainy, filmy looking pics of late. Unfortunately half the "new" film I had turned out to have already been exposed. It just wasn't wound back in to the canister. Hope to get some more exciting pics over the summer using lower ISO film and a film scanner (well, borrow my dad's ...) rather than just scanning 6x4 prints.
A friendly froggy we found crawling up the wall by our marshmallow toasting BBQ session.
Aaron Sly of Sanctorum screaming out new material at The Frog & Nightgown, complete with 80s laser disco lighting.
Charlotte Wessels of Delain sharing a metal moment with new guitarist Timo Somers.
Tiny trampolining. Taken with a 28mm from an upstairs window.
Flowers blooming on the central reservation of the Sheffield inner city ring road.